Just so you know …

Your are not authenticated, you have a restricted access. Feel free to login to get a better user experience.
Free for open source projects. Sign up here

Review of branch master

5990b3169b | the | 19 fixed issues | 23 to go.   |   View branch on GitHub    |   Badge urls

This is a review of an integration branch. Instead of showing the difference between the given branch and the integration, we're showing here below all problems we found in the current codebase, so the list may be long.

This is a public review of a branch. It means that you can read it, even if you never contributed code to it. Be aware that we may hide some sensitive information regarding security issues.

Occured at

 6
 7  class << self
 8    trap('INT') { puts "\nGoodbye!"; exit;  }
 9
10    def start(words_per_minute)
11      puts ' ' * ORP_VISUAL_POS + 'v'.colorize(:red)
 9
10    def start(words_per_minute)
11      puts ' ' * ORP_VISUAL_POS + 'v'.colorize(:red)
12      ARGF.each do |line|
13        words = tokenize(line)
14        words.each do |word|
21        end
22      end
23      puts
24    end
25
26    def tokenize(input)

Why

You don't want to clutter your logs with raw puts, pp, or p. Output using p will not always appear in your logs, nor will it inherit from any log config you may have (to add information such as the timestamp).

How to fix

In a Rails application

Use Rails.logger instead.

In Ruby code

Just use the Logger class.

In unit and integration tests

This is often a sign that you are missing some asserts and other checks.

More info

  • Rails logger
  • Stdlib logger
  • Better logs for Rails using lograge .
  • Fully configurable logs for any Ruby application using log4r (look what Mitchell Hasimoto of Vagrant fame says about it ).

Know a good reference on this subject ? Tell us about it!

Loading more violations...