This is a review of an integration branch. Instead of showing the difference between the given branch and the integration, we're showing here below all problems we found in the current codebase, so the list may be long.
This is a public review of a branch. It means that you can read it, even if you never contributed code to it. Be aware that we may hide some sensitive information regarding security issues.
You don't want to clutter your logs with raw puts, pp, or p. Output using
p will not always appear in your logs, nor will it inherit from any log config
you may have (to add information such as the timestamp).
How to fix
In a Rails application
Use Rails.logger instead.
In Ruby code
Just use the Logger class.
In unit and integration tests
This is often a sign that you are missing some asserts and other checks.